Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocrack fix #187

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Autocrack fix #187

merged 1 commit into from
Sep 17, 2021

Conversation

ecapson
Copy link

@ecapson ecapson commented Sep 16, 2021

This fixes the issue #184 by validating the challenge and response.

Formatting the fifo with known format or encoding each part before inserting in fifo could help the integrity. However, this would require modification to every module using the fifo and would result in more storage usage and time.

s0lst1c3
s0lst1c3 approved these changes Sep 17, 2021
View reviewed changes
Copy link
Owner

@s0lst1c3 s0lst1c3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission - you’re awesome.

@s0lst1c3 s0lst1c3 merged commit e8d1ff8 into s0lst1c3:master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s0lst1c3 s0lst1c3 s0lst1c3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ecapson @s0lst1c3