ignoreDiagnostics like ts-loader

[texastoland]

Close #148.

[texastoland]

CC @yaroslavya

[s-panferov]

@AppShipIt thanks! I'll look through it!

I know that some people find this useful, but in my practice i've never wanted to silence errors. Could you please provide some examples about why do you need this?

[texastoland]

Yeah I'll add a note to the readme as well. The major one is microsoft/TypeScript#6319. TL;DR you cannot get tree shaking from WebPack 2 without it. I took a lot of inspiration from the Rollup plugin (see microsoft/TypeScript#6319 (comment)). But I'm also trying to migrate a legacy code base from Babel. TypeScript complains about a number of constructs (class/instance properties most annoyingly e.g. microsoft/TypeScript#7216) in JavaScript (no types yet) but nonetheless transpiles correctly. It sounds like they plan to be fix that but not soon.

[texastoland]

@s-panferov I refactored the npm scripts too. Let me know if you prefer that in a separate PR.

Edit:
Nixing the Babel step broke the build because you're using it to transpile async…await to ES5. I reverted it and rebased. Compellingly microsoft/TypeScript#1564 (comment) provides another use case for my feature.

[s-panferov]

instanceName disappeared. Was it intentional?

[texastoland]

Noted where it moved to. This just unwrapped errors.map(). Most of the diff is indentation.

[s-panferov]

@AppShipIt hi!, Sorry for the delay, I had a hard work week. I have only two little questions and after that it can be merged.

[s-panferov]

Sorry, my eyes lie to me today. Everything is fine! Thanks again!

[texastoland]

You're right I should've left this line so TS output doesn't get published to npm. The next two lines can still be removed though and maybe add dist.babel/test.

[s-panferov]

Landed as awesome-typescript-loader@0.19.0

[texastoland]

[olegstepura]

@AppShipIt I'm kind of lost. Can we use generators in Typescript with awesome-typescript-loader without the extra compilation step (e.g. Typescript -> ES5, not Typescript -> ES6 (babel here) -> ES5)?

[texastoland]

Generators (or async) cannot currently target ES5 because TS won't ship a runtime until 2.0 (see roadmap). Regardless ignoreDiagnostics has proven useful to compile other not yet fully supported features. Until a very recent beta TS warned against ES2015 modules with ES5 code for tree shaking but emitted mostly correct. Errors transpiling nonstandard features like properties from vanilla JS using the allowJs flag will also eventually work but not within the next couple releases.

[olegstepura]

@AppShipIt so even if we use regenerator we cannot avoid babel step at the moment, right?

[texastoland]

Yes and no. TS will correctly emit async in combination with regenerator-loader and ignoreDiagnostics. But I've tried a couple tricks unsuccessfully to re-emit generator functions. For my team that was acceptable until 2.0.