Add Qingping Air Monitor Lite support (cgllc.airm.cgdn1) #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rytilahti
reviewed
Jan 5, 2021
rytilahti
reviewed
Jan 8, 2021
rytilahti
reviewed
Jan 28, 2021
|
LGTM, one last thing before merging this, could you add an entry to README's supported devices, @arturdobo? |
|
@rytilahti updated, but no idea why the build failed |
|
Looks like a problem at readthedocs' side, could you rebase the README change though? It's conflicting currently with a recently merged PR. |
…, device off and screen off
|
@rytilahti done |
|
Great, thanks for the PR! 🎉 The readthedocs problem seems to be related new rust compiler dependency on cryptography lib, which is not available there. I hope that'll get fixed by itself at some point. |
Merged
xvlady
pushed a commit
to xvlady/python-miio
that referenced
this pull request
May 9, 2021
* Add Qingping Air Monitor Lite support * add test for cgdn1 * fix typo * removed CGDN1 from ChargingState enum * refactored to int be accepted in case of setting monitoring frequency, device off and screen off * added raw response to the doc string * moved enums to device class * fixed typo & exposed options * removed unnecessary enums from class * updated readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Qingping Air Monitor Lite support (
cgllc.airm.cgdn1).Specification: https://miot-spec.org/miot-spec-v2/instance?type=urn:miot-spec-v2:device:air-monitor:0000A008:cgllc-cgdn1:1
Closes: #879
Support
start_timeandend_timehas been intentionally omitted in this PR and can be added in the other one. I didn't check whether the time zone is necessary to compute the current time. If yes, I wasn't able to readtime_zonefrom my device, butcgllc-cgdn1:2spec mentions that property. What's more Xiaomi Home reads somehow this property from the device.Another thing is I had no idea what
0regardingmonitoring_frequencycould mean.