Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add airdog.airpurifier.{x3,x5,x7sm} support #865

Merged
merged 9 commits into from
Nov 23, 2020
Merged

Add airdog.airpurifier.{x3,x5,x7sm} support #865

merged 9 commits into from
Nov 23, 2020

Conversation

syssi
Copy link
Collaborator

@syssi syssi commented Nov 22, 2020 •
edited
Loading

No description provided.

@syssi syssi mentioned this pull request Nov 22, 2020
Open
@syssi syssi requested a review from rytilahti November 22, 2020 15:31
rytilahti
rytilahti approved these changes Nov 22, 2020
View reviewed changes
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, feel free to merge as you wish 👍

miio/airpurifier_airdog.py Outdated Show resolved Hide resolved
@syssi syssi merged commit c7c7ce8 into rytilahti:master Nov 23, 2020
@rytilahti rytilahti mentioned this pull request Mar 13, 2021
Merged
@alexeypetrenko
Copy link
Contributor

@syssi, I've got a small feedback regarding this module.

For this device sleep does not mean that it is off or idle. Probably, more precise term would be night mode. In this mode fan still runs (even slower than on the first speed), display and all the lights are off.

If you don't mind, I'd like to rename Idle to something more appropriate.

xvlady pushed a commit to xvlady/python-miio that referenced this pull request May 9, 2021
@syssi @xvlady
Add airdog.airpurifier.{x3,x5,x7sm} support (rytilahti#865)
835be40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rytilahti rytilahti rytilahti approved these changes

Assignees
No one assigned
Labels
miio new device
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@syssi @alexeypetrenko @rytilahti