Rename the project to python-miio #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 26, 2017
| @@ -1,13 +1,13 @@ | |||
| from setuptools import setup | |||
|
|
|||
| with open('mirobo/version.py') as f: exec(f.read()) | |||
| with open('miio/version.py') as f: exec(f.read()) | |||
There was a problem hiding this comment.
multiple statements on one line (colon)
mirobo/__init__.py
Outdated
| warnings.warn("Please convert to using 'miio' package, this package will " | ||
| "be removed at some point in the future", DeprecationWarning, | ||
| stacklevel=2) | ||
| from miio import * |
There was a problem hiding this comment.
module level import not at top of file
'from miio import ' used; unable to detect undefined names
'miio.' imported but unused
|
Changes Unknown when pulling 186a700 on rename-package into ** on master**. |
|
Looks good! I need a day or two for testing. |
rytilahti
force-pushed
the
rename-package
branch
from
186a700 to
7ffb980
Compare
|
Just tested. Looks good! |
rytilahti
force-pushed
the
rename-package
branch
from
7ffb980 to
0089c22
Compare
This commit renames the project to its new name, python-miio. The name of the package has been changed to 'miio', although the old 'mirobo' is still available for backwards compatibility. Anyone trying to access and use the 'mirobo' package will be welcomed by a deprecation warning, although there are no plans to break the API currently. README.md got also updated to links for other home-assistant integrations available.
rytilahti
force-pushed
the
rename-package
branch
from
0089c22 to
db577ac
Compare
|
Thanks @syssi! And thanks also to @SchumyHao for releasing the new name for our use! :-) A new release will follow during this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit renames the project to its new name, python-miio.
The name of the package has been changed to 'miio',
although the old 'mirobo' is still available for backwards compatibility.
Anyone trying to access and use the 'mirobo' package will be welcomed
by a deprecation warning, although there are no plans to break the API currently.
README.md got also updated to links for other home-assistant integrations available.