yeelight: Check color mode values for emptiness #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeelink.light.mono1 is seemingly reporting color_mode to be 2 (color temperature) even when the light does not support ct. This PR checks that the values for ct (or hue, sat & brightness for hsv mode, and rgb for rgb mode) are not empty. Fixes #802
swim2sun
pushed a commit
to swim2sun/python-miio
that referenced
this pull request
Oct 13, 2020
yeelink.light.mono1 is seemingly reporting color_mode to be 2 (color temperature) even when the light does not support ct. This PR checks that the values for ct (or hue, sat & brightness for hsv mode, and rgb for rgb mode) are not empty. Fixes rytilahti#802
swim2sun
added a commit
to swim2sun/python-miio
that referenced
this pull request
Oct 13, 2020
This reverts commit fc67404.
xvlady
pushed a commit
to xvlady/python-miio
that referenced
this pull request
May 9, 2021
yeelink.light.mono1 is seemingly reporting color_mode to be 2 (color temperature) even when the light does not support ct. This PR checks that the values for ct (or hue, sat & brightness for hsv mode, and rgb for rgb mode) are not empty. Fixes rytilahti#802
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yeelink.light.mono1 is seemingly reporting color_mode to be 2 (color temperature) even when the light does not support ct.
This PR checks that the values for ct (or hue, sat & brightness for hsv mode, and rgb for rgb mode) are not empty.
Fixes #802