-
-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Viomi support (status reporting, maps) #808
Conversation
96886ea
to
04e6195
Compare
@rytilahti ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I did a quick initial review, do you have plans to figure out the unknown variables and are you sure requesting so many variables is not breaking some limits?
edit: some of the consumables are duplicates and already available thanks to #805?
@titilambert Ping? Could you also update the description for the PR? |
dd83750
to
d2e5d1d
Compare
done |
@rytilahti I made a refactoring to have something structured like the android app. |
646029a
to
318eece
Compare
@titilambert Take a look at your inbox. I've sent you an e-mail (subject: "Some material to support your viomi PR"). |
Thanks ! I already had this file but only for viomi.v7 |
2b7267e
to
c1f2895
Compare
@rytilahti I found a way to create a map in live using Pillow. |
@rytilahti I think this PR is now ready ! |
c1f2895
to
e21af11
Compare
@rytilahti The PR is now rebased |
@rytilahti need to get PR #884 merged, then I rebase this one and It will be ready for review |
7a738f4
to
a3c3b5a
Compare
Co-authored-by: Teemu R. <tpr@iki.fi>
Co-authored-by: Teemu R. <tpr@iki.fi>
Co-authored-by: Teemu R. <tpr@iki.fi>
Co-authored-by: Teemu R. <tpr@iki.fi>
Co-authored-by: Teemu R. <tpr@iki.fi>
Co-authored-by: Teemu R. <tpr@iki.fi>
There is a lot of comments in this PR, and it's very hard to see what is now resolved and what still needs work.
|
The voice volume is set using integers ranging from 1 to 10, represented in the app as 10% to 100%. I assume this is the same as other Xiaomi models? Here's logs from the Mi Home app with me setting the volume to 90% and then back to 100%:
When disabling the voice, the parameters become [0,5] (presumably, "off" and "50%") and the app hides the volume setting. When re-enabling, the app sets the voice volume to 50% regardless of what volume it was originally. The following is the result of me disabling the voice when it is was 100% volume, and then re-enabling, and manually setting the volume back to 100%:
|
Co-authored-by: Teemu R. <tpr@iki.fi>
@rytilahti I just fixed all your comments and the tests are green :) |
Okay, let's get it merged, thanks for the PR and for your patience! 🎉 For further improvements, let's try to do it more gradually (i.e., with smaller, self-contained changes) to make it easier & faster to review! |
I use this App too. Where can I find this log? Maybe there is a easy way to get the coordinates for zoned-cleaning. |
create /vevs/logs/ and kill app. you will find everything (also zone clean coords) in /vevs/logs/miio/did.txt where did is your device id. |
* Improve viomi vacuum status * Fix missing char. * Update miio/viomivacuum.py Co-authored-by: Teemu R. <tpr@iki.fi> * Update miio/viomivacuum.py Co-authored-by: Teemu R. <tpr@iki.fi> * Update miio/viomivacuum.py Co-authored-by: Teemu R. <tpr@iki.fi> * Update miio/viomivacuum.py Co-authored-by: Teemu R. <tpr@iki.fi> * Update miio/viomivacuum.py Co-authored-by: Teemu R. <tpr@iki.fi> * Update miio/viomivacuum.py Co-authored-by: Teemu R. <tpr@iki.fi> * Fix PR comments * Fix PR comments * Fix PR comments * Update miio/viomivacuum.py Co-authored-by: Teemu R. <tpr@iki.fi> * Fix PR comments * Fix PR comments * Fix PR comments Co-authored-by: Teemu R. <tpr@iki.fi>
This PR refactors viomi vacuum (like STYJ02YM)
I tested all the attributes with STYJ02YM.
I re-organised the commands to stick with the android UI.
I added also some commands: