WIP: Avoid discovery flooding #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added the loop in f35910e as in some point the robot was not always responsive. However, maybe that has been fixed since then or was just a problem with my network (hard to say), so I don't think there's much harm if we merge this and see if it all works just fine now. I have been running it with this patch for some time now and tested that everything is still functioning. |
|
Unfortunately it looks like this breaks the connectivity with the vacuum, it was a bit too early to get it merged.. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just added the first of probably two needed changes to fix the discovery of some devices (water purifier, vacuum(?)).