Add new device type mappings, add note about 'used_for_public' #713
Conversation
Not entirely sure what this command does, but I think it has to do with enabeling/disabeling developer mode. In any case, I came accross this command while sniffing gateway trafic
|
I'm a bit hesitant on adding functionality that is unclear, as that can simply be consuming to both API and cli users. How about adding these to the list of known, but unknown commands in the docstring instead? However, if you really want to have this in, then it should be a single command |
|
I understand |
|
Great, agreed! One more thing, did you test those? It would also be worth describing the return values for the future. |
|
I looked at the sniffing and saw the set and get values [1] and 1, so presumably the other value will be 0 for off, but do not dare to test because I don't know what it is going to mess up..... anyway I added the return values to the docstring and also added 2 more device types from issue #650 |
rytilahti
changed the title
|
I updated the title, this can be merged as soon as the CI passes. |
|
@rytilahti CI has passed, so this is now ready to be merged |
…ahti#713) * add 'used_for_public' getter and setter Not entirely sure what this command does, but I think it has to do with enabeling/disabeling developer mode. In any case, I came accross this command while sniffing gateway trafic * move used_for_public to comments * remove space * add 2 devices and the zigbee_ids as comments * add values to used_for_public * add zigbee_id * fix black formatting
Not entirely sure what this command does, but I think it has to do with enabeling/disabeling developer mode.
In any case, I came accross this command while sniffing gateway trafic