Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eyecare on/off to philips_eyecare_cli #631

Merged
merged 2 commits into from
Feb 18, 2020
Merged

Add eyecare on/off to philips_eyecare_cli #631

merged 2 commits into from
Feb 18, 2020

Conversation

hhrsscc
Copy link
Contributor

@hhrsscc hhrsscc commented Feb 18, 2020

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.044% when pulling db8b610 on hhrsscc:master into b905757 on rytilahti:master.

rytilahti
rytilahti approved these changes Feb 18, 2020
View reviewed changes
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after adjusting the docstrings, thanks 👍

miio/philips_eyecare_cli.py Outdated Show resolved Hide resolved
miio/philips_eyecare_cli.py Outdated Show resolved Hide resolved
@rytilahti rytilahti merged commit efd4370 into rytilahti:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rytilahti rytilahti rytilahti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hhrsscc @coveralls @rytilahti