Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SmartMi Zhimi Heaters #625

Merged
merged 8 commits into from
Feb 13, 2020
Merged

Add support for SmartMi Zhimi Heaters #625

merged 8 commits into from
Feb 13, 2020

Conversation

bazuchan
Copy link
Contributor

@bazuchan bazuchan commented Feb 10, 2020 •
edited by rytilahti
Loading

Adds support for the following new devices:

  • Smartmi Radiant Heater Smart Version (ZA1 version)
  • Xiaomi Mi Smart Space Heater

Closes #615

@coveralls
Copy link

coveralls commented Feb 10, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 74.044% when pulling bcd5769 on bazuchan:heater into ba8d1bb on rytilahti:master.

rytilahti
rytilahti reviewed Feb 12, 2020
View reviewed changes
Copy link
Owner

@rytilahti rytilahti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It looks good to me, left a couple of comments inline.

Please also update the device list in README.md.

miio/heater.py Outdated Show resolved Hide resolved
miio/heater.py Show resolved Hide resolved
rytilahti
rytilahti reviewed Feb 13, 2020
View reviewed changes
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor stylistic changes to improve readability & update to the README.md are the remaining tasks before getting this merged.

miio/heater.py Show resolved Hide resolved
miio/heater.py Show resolved Hide resolved
miio/heater.py Show resolved Hide resolved
miio/heater.py Show resolved Hide resolved
miio/heater.py Show resolved Hide resolved
@bazuchan
Copy link
Contributor Author

Some minor stylistic changes to improve readability & update to the README.md are the remaining tasks before getting this merged.

Done. Device names in README as in MiHome App (Market names way too different and confusing).

BTW ZA2 model seems to support only miot protocol.

@rytilahti rytilahti changed the title Add SmartMi Zhimi Heaters Add support for SmartMi Zhimi Heaters Feb 13, 2020
@rytilahti
Copy link
Owner

One last thing, could you also update discovery.py accordingly. I added a note about za2 to #627, thanks!

@bazuchan
Copy link
Contributor Author

One last thing, could you also update discovery.py accordingly.

Done

@rytilahti rytilahti merged commit b905757 into rytilahti:master Feb 13, 2020
@rytilahti rytilahti mentioned this pull request Nov 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rytilahti rytilahti rytilahti left review comments

Assignees
No one assigned
Labels
new device
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Smartmi Radiant Heater Smart Version (zhimi.heater.za2)
3 participants
@bazuchan @coveralls @rytilahti