Add support for deerma.humidifier.mjjsq #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 3, 2019
syssi
force-pushed
the
feature/deerma-humidifier-mjjsq-support
branch
from
a986d8c to
3cd2a93
Compare
rytilahti
reviewed
Dec 4, 2019
rytilahti
approved these changes
Dec 4, 2019
| @property | ||
| def power(self) -> str: | ||
| """Power state.""" | ||
| return "on" if self.data["OnOff_State"] == 1 else "off" |
There was a problem hiding this comment.
Is there a need to have both power and is_on? I'd prefer simply a single boolean variant of one of these.
There was a problem hiding this comment.
I would like to stick on this because of consistency and a nice status output of: "Power: on"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #533