Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve toiletlid various parameters #579

Merged
merged 4 commits into from
Nov 28, 2019
Merged

Improve toiletlid various parameters #579

merged 4 commits into from
Nov 28, 2019

Conversation

scp10011
Copy link
Contributor

1.add work_state analysis
2.add xiaomi_band interface

@scp10011
Improve various parameters
f9f3514 
1.add work_state analysis
2.add xiaomi_band interface
@scp10011
ci
8156eee
@scp10011
update unittest
e3f52ee
@coveralls
Copy link

coveralls commented Nov 26, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 72.061% when pulling 8a4dabe on scp10011:master into 8cb8fb6 on rytilahti:master.

rytilahti
rytilahti reviewed Nov 27, 2019
View reviewed changes
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks generally good to me, I left behind a couple of potential improvements, please let me know what do you think.

miio/toiletlid.py Outdated Show resolved Hide resolved
miio/toiletlid.py Show resolved Hide resolved
@scp10011
work_mode return ToiletlidOperatingMode type
8a4dabe 
un/bind_xiaomi_band  return bind or unbind result
@rytilahti rytilahti merged commit 8ff03fd into rytilahti:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rytilahti rytilahti rytilahti left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scp10011 @coveralls @rytilahti