Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add azure pipeline for tests, and enforce black, flake8 and isort for commits #566

Merged
merged 7 commits into from
Oct 27, 2019

Conversation

rytilahti
Copy link
Owner

@rytilahti rytilahti commented Oct 27, 2019

Up for discussion :-) Having all formating enforced by the pre-commit makes it easy to contribute without having to worry about that. Travis, Hound, and Coveralls could be disabled in the future.

I'd prefer adding mypy checks also, but that will require a bit more work to make it happen.

  • Add pre-commit hooks for flake8, isort.
  • Use azure dev for running precommit checks and tests.
  • Use black's default line length (88) instead of (100). This seems to work fine.

miio/vacuum.py Show resolved Hide resolved
miio/tests/test_philips_moonlight.py Show resolved Hide resolved
miio/device.py Show resolved Hide resolved
miio/airqualitymonitor.py Show resolved Hide resolved
Copy link
Collaborator

@syssi syssi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Let's give it a try. Feel free to merge.

@rytilahti rytilahti changed the title use azure pipeline instead of travis add azure pipeline for tests, and enforce black, flake8 and isort for commits Oct 27, 2019
@rytilahti rytilahti merged commit c8060fc into master Oct 27, 2019
@rytilahti rytilahti deleted the azure-pipelines branch October 27, 2019 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants