Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 0.4.6 #541

Merged
merged 9 commits into from
Oct 2, 2019
Merged

Conversation

syssi
Copy link
Collaborator

@syssi syssi commented Aug 14, 2019

No description provided.

@syssi syssi requested a review from rytilahti August 14, 2019 11:17
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, feel free to merge and release (and wow, it's been a while considering the number of new devices)!

@@ -1,5 +1,71 @@
# Change Log

This release adds support for the following new devices:

* Xiaomi Air Quality Monitor S1 \(cgllc.airmonitor.s1\)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parentheses are escaped here but not some lines below.

* Vacuum: Add state 18 as "segment cleaning"
* Device: Add easily accessible properties to DeviceError exception
* Always import DeviceError exception
* Require click version \>=7
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Escaping also here (and above for _).

@shaymdev
Copy link

I'm following this in anticipation of segment cleaning for the s6 vacuum (and hoping for rapid home assistant upgrade to your new 0.4.6). Anything I can do to help out?

@rytilahti
Copy link
Owner

There has been some more new changes since creation of this PR, so the changelog needs to be updated before the release.

If you want to help, I think the best way to do that would be to see how to integrate segment cleaning on homeassistant's end against master branch of python-miio. That way it'd be fast to fix before releasing a new version and bumping the homeassistant requirement.

@@ -69,3 +69,51 @@ def test_status(self):
assert self.state().usb_power is (self.device.start_state["usb_state"] == 'on')
assert self.state().display_clock is (self.device.start_state["time_state"] == 'on')
assert self.state().night_mode is (self.device.start_state["night_state"] == 'on')

class DummyAirQualityMonitorS1(DummyDevice, AirQualityMonitor):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected 2 blank lines, found 1

@@ -3,11 +3,11 @@
import pytest

from miio import AirQualityMonitor
from miio.airqualitymonitor import AirQualityMonitorStatus, MODEL_AIRQUALITYMONITOR_V1
from miio.airqualitymonitor import AirQualityMonitorStatus, MODEL_AIRQUALITYMONITOR_V1, MODEL_AIRQUALITYMONITOR_S1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (114 > 100 characters)

@syssi syssi merged commit 5184dcf into rytilahti:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants