Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Air purifier: defaultdict used for safety and transparency #49

Merged

Conversation

syssi
Copy link
Collaborator

@syssi syssi commented Sep 3, 2017

I like to avoid property errors. cp. syssi/xiaomi_airpurifier#4

"count (%s) of received values.",
properties_count, values_count)

return CeilStatus(defaultdict(lambda: None, zip(properties, values)))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undefined name 'CeilStatus'
undefined name 'defaultdict'

"count (%s) of received values.",
properties_count, values_count)

return AirPurifierStatus(defaultdict(lambda: None, zip(properties, values)))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (84 > 79 characters)

@syssi
Copy link
Collaborator Author

syssi commented Sep 3, 2017

I would be happy about a bugfix release.

@rytilahti
Copy link
Owner

Looks good, thanks.

@rytilahti rytilahti merged commit 0a28bde into rytilahti:master Sep 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants