Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected link in discovery.rst and Xiaomi Air Purifier Pro fix #465

Merged
merged 3 commits into from
Jan 21, 2019
Merged

Corrected link in discovery.rst and Xiaomi Air Purifier Pro fix #465

merged 3 commits into from
Jan 21, 2019

Conversation

swiergot
Copy link
Contributor

I hope you don't mind I also include a small fix for Air Purifier Pro. I cannot see any distinction between different Air Purifier models. Either this code doesn't care that some models might not accept higher values or so far all models have had a max of 16. Please advise.

@rytilahti rytilahti requested a review from syssi January 21, 2019 18:03
@syssi
Copy link
Collaborator

syssi commented Jan 21, 2019

@swiergot Could you update the unit tests, too! :-)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.461% when pulling 0432ac4 on swiergot:master into 5dd2abb on rytilahti:master.

@syssi syssi merged commit 9886169 into rytilahti:master Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syssi syssi syssi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swiergot @syssi @coveralls