AC Partner V3: Add socket support (Closes #337) #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 17, 2018
miio/airconditioningcompanion.py
Outdated
| return self.send("toggle_plug", ["on"]) | ||
|
|
||
| @command( | ||
| default_output = format_output("Powering socket off"), |
There was a problem hiding this comment.
unexpected spaces around keyword / parameter equals
miio/airconditioningcompanion.py
Outdated
| @@ -284,6 +284,20 @@ def off(self): | |||
| """Turn the air condition off by infrared.""" | |||
| return self.send("set_power", ["off"]) | |||
|
|
|||
| @command( | |||
| default_output = format_output("Powering socket on"), | |||
There was a problem hiding this comment.
unexpected spaces around keyword / parameter equals
houndci-bot
reviewed
Nov 18, 2018
| def test_status(self): | ||
| self.device._reset_state() | ||
|
|
||
| assert repr(self.state()) == repr(AirConditioningCompanionStatus(dict(model_and_state=self.device.start_state, power_socket=self.device.start_device_prop['lumi.0']['plug_state']))) |
There was a problem hiding this comment.
line too long (188 > 100 characters)
| @@ -126,7 +128,7 @@ def test_off(self): | |||
| def test_status(self): | |||
| self.device._reset_state() | |||
|
|
|||
| assert repr(self.state()) == repr(AirConditioningCompanionStatus(self.device.start_state)) | |||
| assert repr(self.state()) == repr(AirConditioningCompanionStatus(dict(model_and_state=self.device.start_state))) | |||
There was a problem hiding this comment.
line too long (120 > 100 characters)
rytilahti
approved these changes
Nov 18, 2018
miio/airconditioningcompanion.py
Outdated
| @@ -208,7 +227,7 @@ def fan_speed(self) -> Optional[FanSpeed]: | |||
| def mode(self) -> Optional[OperationMode]: | |||
| """Current operation mode.""" | |||
| try: | |||
| mode = int(self.data[1][3:4]) | |||
| mode = int(self.data['model_and_state'][1][3:4]) | |||
There was a problem hiding this comment.
Considering all of these access the same structure, would it make sense to have a variable for it? Like self.state = self.data['model_and_state'][1]?
| if model in MODELS_SUPPORTED: | ||
| self.model = model | ||
| else: | ||
| self.model = MODEL_ACPARTNER_V2 |
There was a problem hiding this comment.
This defaults to v2 if an unknown model is given? Maybe add a warning logging for that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.