Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some improvements of the air purifier support #40

Merged
merged 3 commits into from
Aug 27, 2017
Merged

Some improvements of the air purifier support #40

merged 3 commits into from
Aug 27, 2017

Conversation

syssi
Copy link
Collaborator

@syssi syssi commented Aug 26, 2017 •
edited
Loading

I cleaned up the code, improved some edge cases and added missing methods.

rytilahti
rytilahti approved these changes Aug 27, 2017
View reviewed changes
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the second response example, it will help creating unit tests for the library later on!

@rytilahti rytilahti merged commit 672628a into rytilahti:master Aug 27, 2017
@syssi syssi mentioned this pull request Sep 3, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rytilahti rytilahti rytilahti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syssi @rytilahti