WiFi Repeater: Wifi roaming and signal strange indicator added #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rytilahti
approved these changes
Mar 30, 2018
miio/wifirepeater.py
Outdated
| @@ -86,12 +91,38 @@ def set_wifi_roaming(self, wifi_roaming: bool): | |||
| 'wifi_explorer': int(wifi_roaming) | |||
| }]) | |||
|
|
|||
| def set_configuration(self, ssid: str, password: str, hidden: bool = False, | |||
| wifi_roaming: bool = False): | |||
| def set_configuration(self, wifi_roaming: bool = False, ssid: str = None, | |||
There was a problem hiding this comment.
Would it make sense to have a separate method for enabling and disabling the roaming? Otherwise this looks good to be merged.
There was a problem hiding this comment.
Good idea! I will care about!
syssi
force-pushed
the
feature/xiaomi-repeater-extended
branch
from
f514ffa
to
07ce546
Compare
houndci-bot
reviewed
Mar 31, 2018
miio/wifirepeater.py
Outdated
| @@ -1,9 +1,14 @@ | |||
| import logging | |||
| from .device import Device | |||
| from typing import Optional | |||
There was a problem hiding this comment.
'typing.Optional' imported but unused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.