Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a breaking change of construct 2.9.23 #192

Merged
merged 1 commit into from
Jan 28, 2018

Conversation

syssi
Copy link
Collaborator

@syssi syssi commented Jan 28, 2018

Parameter "context" of the parse method was replaced by **kw.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 66.963% when pulling 9368d8b on syssi:feature/fix-fox-construct-2.9.23 into b0c04cf on rytilahti:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 66.963% when pulling 9368d8b on syssi:feature/fix-fox-construct-2.9.23 into b0c04cf on rytilahti:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 66.963% when pulling 9368d8b on syssi:feature/fix-fox-construct-2.9.23 into b0c04cf on rytilahti:master.

@syssi syssi merged commit 17c7a26 into rytilahti:master Jan 28, 2018
@yawor
Copy link
Contributor

yawor commented Jan 28, 2018

Maybe we really should pin the Construct to specific version in setup.py, and monitor for new versions from time to time. That way the released versions of the library won't break because of some backward incompatible change in the dependency.

Also you could just change ctx to **ctx :). But this is also fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants