Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid cache handling for miotcloud schema fetch #1819

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

rytilahti
Copy link
Owner

The cache read raises an exception instead of returning None when no schema file has been downloaded.

Fixes #1818

@rytilahti rytilahti added the bug label Aug 30, 2023
@rytilahti rytilahti force-pushed the fix/miotcloud_get_device_model branch from 8b5d10a to 6ad3977 Compare August 30, 2023 17:07
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #1819 (8b5d10a) into master (2546b04) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 8b5d10a differs from pull request most recent head 6ad3977. Consider uploading reports for the commit 6ad3977 to get more accurate results

@@            Coverage Diff             @@
##           master    #1819      +/-   ##
==========================================
- Coverage   80.82%   80.81%   -0.01%     
==========================================
  Files         192      192              
  Lines       18541    18543       +2     
  Branches     4014     4013       -1     
==========================================
  Hits        14985    14985              
- Misses       3278     3280       +2     
  Partials      278      278              
Files Changed Coverage Δ
miio/miot_cloud.py 73.75% <0.00%> (-1.90%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit 4039842 into master Sep 18, 2023
@rytilahti rytilahti deleted the fix/miotcloud_get_device_model branch September 18, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INFO cmd return a FileNotFoundError
1 participant