Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark xiaomi.wifispeaker.l05g as supported for ChuangmiIr #1804

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

danielszilagyi
Copy link
Contributor

Related issue.

The IR control part of the device works properly:

root@DS718:/# miiocli chuangmiir --ip 192.168.0.241 --token xx learn 32
Learning command into storage key 32
WARNING:miio.device:Found an unsupported model 'xiaomi.wifispeaker.l05g' for class 'ChuangmiIr'. If this is working for you, please open an issue at https://github.com/rytilahti/python-miio/
['ok']
root@DS718:/# miiocli chuangmiir --ip 192.168.0.241 --token xx read 32
Reading infrared command from storage key 32
WARNING:miio.device:Found an unsupported model 'xiaomi.wifispeaker.l05g' for class 'ChuangmiIr'. If this is working for you, please open an issue at https://github.com/rytilahti/python-miio/
{'key': '32', 'code': 'mk1mMwlk0mk4mEsmwBBTWZABlOQAymgB6zGbTUBBZjNpuBDIDMAIWBkc1AkIANATimoHMTYEKgXHAQkB0wGHAyMDpwFymM2AUMDqwCFAiKYzYCcwK3AzoEtAOzm8wCH0HVwB4A4YFvwEamk2mYEhTQDE5pNALnBXeYzKazCYTAA='}
root@DS718:/# miiocli chuangmiir --ip 192.168.0.241 --token xx play 32
Playing the supplied command
WARNING:miio.device:Found an unsupported model 'xiaomi.wifispeaker.l05g' for class 'ChuangmiIr'. If this is working for you, please open an issue at https://github.com/rytilahti/python-miio/
['ok']

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #1804 (d89d0d1) into master (673a421) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1804   +/-   ##
=======================================
  Coverage   80.70%   80.70%           
=======================================
  Files         192      192           
  Lines       18511    18511           
  Branches     4012     4012           
=======================================
  Hits        14939    14939           
  Misses       3295     3295           
  Partials      277      277           
Files Changed Coverage Δ
miio/integrations/chuangmi/remote/chuangmi_ir.py 89.53% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the PR, Daniel! The CI failures are unrelated, so I'll just merge this.

@rytilahti rytilahti changed the title Add xiaomi.wifispeaker.l05g to supported devices Mark xiaomi.wifispeaker.l05g as supported for ChuangmiIr Aug 3, 2023
@rytilahti rytilahti merged commit b7a20a3 into rytilahti:master Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants