Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Roborock Q7+ (a40) as supported for roborock #1704

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Mark Roborock Q7+ (a40) as supported for roborock #1704

merged 1 commit into from
Feb 2, 2023

Conversation

andyloree
Copy link
Contributor

Added Roborock Q7+ (a40) to supported_models

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2023

Codecov Report

Merging #1704 (2830349) into master (7e7834a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #1704   +/-   ##
=======================================
  Coverage   81.74%   81.74%           
=======================================
  Files         191      191           
  Lines       17934    17935    +1     
  Branches     3845     3845           
=======================================
+ Hits        14660    14661    +1     
  Misses       2986     2986           
  Partials      288      288           
Impacted Files Coverage Δ
miio/integrations/roborock/vacuum/vacuum.py 64.17% <100.00%> (+0.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andyloree! 👍 If you don't mind, please submit the output from the fw features command to https://github.com/marcelrv/XiaomiRobotVacuumProtocol/blob/master/fw_features.md#firmware-features

@rytilahti rytilahti changed the title Added Roborock Q7+ (a40) Mark Roborock Q7+ (a40) as supported for roborock Feb 2, 2023
@rytilahti rytilahti merged commit 71cd099 into rytilahti:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants