Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cloud interface and cli #1699

Merged
merged 6 commits into from
Jan 29, 2023
Merged

Conversation

rytilahti
Copy link
Owner

  • Expose available locales
  • Convert to use pydantic
  • Use rich for pretty printing
  • Expose extra data contained in the cloud responses

* Expose available locales
* Convert to use pydantic
* Use rich for pretty printing
* Expose extra data contained in the cloud responses
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2023

Codecov Report

Merging #1699 (6eff2d1) into master (aeadb4c) will increase coverage by 0.20%.
The diff coverage is 67.21%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1699      +/-   ##
==========================================
+ Coverage   81.45%   81.66%   +0.20%     
==========================================
  Files         191      191              
  Lines       17897    17913      +16     
  Branches     3843     3843              
==========================================
+ Hits        14578    14628      +50     
+ Misses       3031     2997      -34     
  Partials      288      288              
Impacted Files Coverage Δ
miio/cloud.py 67.69% <66.66%> (+34.35%) ⬆️
miio/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit 6814f32 into master Jan 29, 2023
@rytilahti rytilahti deleted the feat/improve_cloudinterface branch January 29, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants