Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viomivacuum: Fix incorrect attribute accesses on status output #1677

Merged
merged 1 commit into from
Jan 15, 2023

Conversation

rytilahti
Copy link
Owner

The output formatter for status command was accessing non-existing attributes. This also includes fixing the return type for repeat_cleaning.

@rytilahti rytilahti added the bug label Jan 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2023

Codecov Report

Merging #1677 (d94b8d6) into master (d4b939c) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master    #1677   +/-   ##
=======================================
  Coverage   80.01%   80.01%           
=======================================
  Files         161      161           
  Lines       16136    16136           
  Branches     3637     3637           
=======================================
  Hits        12912    12912           
  Misses       2960     2960           
  Partials      264      264           
Impacted Files Coverage Δ
miio/integrations/vacuum/viomi/viomivacuum.py 59.36% <50.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit fa7e189 into master Jan 15, 2023
@rytilahti rytilahti deleted the viomi/fix/incorrect_status_output branch January 15, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants