Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect super().__getattr__() use on devicestatus #1676

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

rytilahti
Copy link
Owner

Trying to access non-existing attributes causes Exception: 'super' object has no attribute '__getattr__' as object class does not have that dunder method.

@rytilahti rytilahti added the bug label Jan 15, 2023
@rytilahti rytilahti force-pushed the fix/devicestatus_invalid_access branch from 3b65ddb to 5cd33e1 Compare January 15, 2023 20:47
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2023

Codecov Report

Merging #1676 (ec20acf) into master (d4b939c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1676      +/-   ##
==========================================
+ Coverage   80.01%   80.04%   +0.02%     
==========================================
  Files         161      161              
  Lines       16136    16136              
  Branches     3637     3637              
==========================================
+ Hits        12912    12916       +4     
+ Misses       2960     2958       -2     
+ Partials      264      262       -2     
Impacted Files Coverage Δ
miio/click_common.py 53.62% <ø> (ø)
miio/devicestatus.py 93.97% <100.00%> (+4.81%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti force-pushed the fix/devicestatus_invalid_access branch from 5cd33e1 to ec20acf Compare January 15, 2023 20:50
@rytilahti rytilahti merged commit 2791c39 into master Jan 19, 2023
@rytilahti rytilahti deleted the fix/devicestatus_invalid_access branch January 19, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants