Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make simulators return localhost address for info query #1657

Merged
merged 1 commit into from
Jan 8, 2023

Conversation

rytilahti
Copy link
Owner

This will make it possible to directly use the data returned by the info query for further uses.

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2023

Codecov Report

Merging #1657 (a39f2ce) into master (03880f0) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #1657   +/-   ##
=======================================
  Coverage   80.41%   80.41%           
=======================================
  Files         161      161           
  Lines       16026    16026           
  Branches     3614     3614           
=======================================
  Hits        12887    12887           
  Misses       2876     2876           
  Partials      263      263           
Impacted Files Coverage Δ
miio/devtools/simulators/common.py 0.00% <0.00%> (ø)
miio/devtools/simulators/miiosimulator.py 0.00% <0.00%> (ø)
miio/devtools/simulators/miotsimulator.py 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit ae35d8a into master Jan 8, 2023
@rytilahti rytilahti deleted the fix/simulator_ip_address branch January 8, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants