Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use type instead of string for SensorDescriptor type #1597

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

rytilahti
Copy link
Owner

The descriptor reports now the return type of the property instead of artificial "sensor" or "binary_sensor", leaving it to the downstream to handle it as they wish.

@rytilahti
Copy link
Owner Author

Ping @starkillerOG just so that you are also in the loop, this fixes the case where binary sensors (that is, sensors returning bool) were constructed as regular sensors in the homeassistant fork.

@rytilahti rytilahti force-pushed the fix/return_type_as_type branch from 5e4ed7c to ab43168 Compare November 15, 2022 17:15
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2022

Codecov Report

Merging #1597 (7f9e4f0) into master (7f9e4f0) will not change coverage.
The diff coverage is n/a.

❗ Current head 7f9e4f0 differs from pull request most recent head ab43168. Consider uploading reports for the commit ab43168 to get more accurate results

@@           Coverage Diff           @@
##           master    #1597   +/-   ##
=======================================
  Coverage   80.86%   80.86%           
=======================================
  Files         157      157           
  Lines       15322    15322           
  Branches     3333     3333           
=======================================
  Hits        12390    12390           
  Misses       2676     2676           
  Partials      256      256           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit 6ee7db0 into master Nov 15, 2022
@rytilahti rytilahti deleted the fix/return_type_as_type branch November 15, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants