Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default unit to None in sensor decorator #1590

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

starkillerOG
Copy link
Contributor

Split out from: #1586
fix sensor unit beeing set to "" instead of None (HomeAssistant default)

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2022

Codecov Report

Merging #1590 (d54a95d) into master (b5a2940) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1590   +/-   ##
=======================================
  Coverage   80.88%   80.88%           
=======================================
  Files         156      156           
  Lines       15254    15254           
  Branches     3283     3283           
=======================================
  Hits        12338    12338           
  Misses       2667     2667           
  Partials      249      249           
Impacted Files Coverage Δ
miio/devicestatus.py 90.27% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@starkillerOG starkillerOG mentioned this pull request Nov 9, 2022
@rytilahti rytilahti changed the title fix default unit to be None default unit to None in sensor decorator Nov 9, 2022
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@starkillerOG
Copy link
Contributor Author

@rytilahti ready to be merged.

@rytilahti rytilahti merged commit db40713 into rytilahti:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants