Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize descriptor extras using factory #1575

Merged
merged 1 commit into from
Nov 6, 2022
Merged

Initialize descriptor extras using factory #1575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions miio/descriptors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class ActionDescriptor:
name: str
method_name: Optional[str] = None
method: Optional[Callable] = None
extras: Optional[Dict] = attr.ib(default={})
extras: Dict = attr.ib(factory=dict)


@attr.s(auto_attribs=True)
Expand All @@ -42,7 +42,7 @@ class SensorDescriptor:
name: str
property: str
unit: Optional[str] = None
extras: Optional[Dict] = attr.ib(default={})
extras: Dict = attr.ib(factory=dict)


class SettingType(Enum):
Expand All @@ -63,7 +63,7 @@ class SettingDescriptor:
type = SettingType.Undefined
setter: Optional[Callable] = None
setter_name: Optional[str] = None
extras: Optional[Dict] = attr.ib(default={})
extras: Dict = attr.ib(factory=dict)

def cast_value(self, value):
"""Casts value to the expected type."""
Expand Down