Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preliminary support for managing sound files #154

Merged
merged 4 commits into from
Jan 18, 2018
Merged

Conversation

rytilahti
Copy link
Owner

  • Adds install_sound which expects url, md5sum and id
  • Adds printing of current sound volume to sound output.

Adds install_sound which expects url, md5sum and id
@rytilahti
Copy link
Owner Author

Requires testing & updating the docs accordingly, an open question is what should be used as a "id" (the current one can be queried with 'sound') for newly installed ones. Another open question is how to switch between languages without doing a "full" installation.

@coveralls
Copy link

coveralls commented Jan 5, 2018

Coverage Status

Coverage decreased (-0.2%) to 62.864% when pulling 10ce6e9 on sound_commands into dd76fcd on master.

* sound_install works now, displays installation state during installation
* SoundInstallStatus and SoundStatus are new sound-related containers
* get_sound_volume returns now an integer, requires a recent FW
@coveralls
Copy link

coveralls commented Jan 15, 2018

Coverage Status

Coverage decreased (-0.3%) to 62.738% when pulling 3d5cac2 on sound_commands into dd76fcd on master.

@coveralls
Copy link

coveralls commented Jan 15, 2018

Coverage Status

Coverage decreased (-0.3%) to 62.738% when pulling 124c791 on sound_commands into dd76fcd on master.

@rytilahti rytilahti changed the title WIP: Add preliminary support for managing sound files Add preliminary support for managing sound files Jan 15, 2018
@rytilahti
Copy link
Owner Author

rytilahti commented Jan 15, 2018

I think this can be merged now, I just tested out generating an audio pack and then installing it afterwards. To simplify the process, the server functionality worked in #153 will be used by this functionality when its done.

To add to the earlier comments by myself, looks like the id can be chosen as you wish (however, passing e.g. 0 gives an error). Furthermore, there seems to be no way to change the sound pack without a download; spamming sids will likely cause filling up the hard drive of the robot.

@coveralls
Copy link

coveralls commented Jan 15, 2018

Coverage Status

Coverage decreased (-0.3%) to 62.738% when pulling 05b5e9a on sound_commands into dd76fcd on master.

@rytilahti rytilahti merged commit 8032eec into master Jan 18, 2018
@rytilahti rytilahti deleted the sound_commands branch January 18, 2018 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants