Add Roborock S7 mop scrub intensity

[shred86]

The Roborock S7 has the option to control the scrub intensity with four different settings:

• Close (raised position)
• Mild
• Moderate
• Intense

The way to control these settings is actually identical to the current waterflow code using self.send("get_water_box_custom_mode") and self.send("set_water_box_custom_mode"). My initial thought was to just add a new MopIntensity class since the names of the settings are different and add a case to the existing waterflow and set_waterflow methods, so if it's an S7 it uses the new MopIntensity. However, the method names don't really make sense (which I'm assuming we don't want to change to prevent breaking apps relying on this library) so my thought is the better option is just to duplicate the methods with a new name.

Addresses #1215

[rytilahti]

My initial thought was to just add a new MopIntensity class since the names of the settings are different and add a case to the existing waterflow and set_waterflow methods, so if it's an S7 it uses the new MopIntensity. However, the method names don't really make sense (which I'm assuming we don't want to change to prevent breaking apps relying on this library) so my thought is the better option is just to duplicate the methods with a new name.

I think it makes sense to have a separate method as it makes the API cleaner. That being said, there's nothing that prevents us changing the method names if necessary, we can always deprecate the old name and make it a wrapper to call the new functionality prior to removing it.

[shred86]

Ah, good point. Well, I do think having it separate would probably be better for future considerations anyways. I wouldn't be surprised to see robot vacuums start being released with both a water and scrub intensity setting.

[codecov-commenter]

Codecov Report

Merging #1236 (740a2ac) into master (4342e3d) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1236      +/-   ##
==========================================
+ Coverage   79.26%   79.30%   +0.04%     
==========================================
  Files          90       90              
  Lines        9729     9748      +19     
  Branches     1130     1171      +41     
==========================================
+ Hits         7712     7731      +19     
  Misses       1825     1825              
  Partials      192      192              

Impacted Files	Coverage Δ
.../integrations/vacuum/roborock/tests/test_vacuum.py	98.31% <100.00%> (+0.23%)	⬆️
miio/integrations/vacuum/roborock/vacuum.py	62.84% <100.00%> (+1.52%)	⬆️
miio/gateway/alarm.py	55.55% <0.00%> (-15.18%)	⬇️
miio/gateway/light.py	27.27% <0.00%> (-13.03%)	⬇️
miio/gateway/zigbee.py	57.14% <0.00%> (-10.72%)	⬇️
miio/gateway/radio.py	52.50% <0.00%> (-6.20%)	⬇️
miio/gateway/gatewaydevice.py	66.66% <0.00%> (-4.77%)	⬇️
miio/waterpurifier_yunmi.py	65.34% <0.00%> (-0.66%)	⬇️
miio/integrations/yeelight/__init__.py	87.22% <0.00%> (-0.56%)	⬇️
miio/cooker.py	58.30% <0.00%> (-0.19%)	⬇️
... and 16 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4342e3d...740a2ac. Read the comment docs.

[rytilahti]

Would you mind adding a couple of tests to make sure this also stays working in case this gets refactored in the future? This is otherwise good to go 👍

[shred86]

Will do! Any ideas how I can change self._model within a test method? It's been a while since I've messed with tests and after about an hour of searching, I'm a bit stumped. The DummyVacuum test class is initialized with self._model = "missing.model.vacuum" but I basically need to change that to "roborock.vacuum.a15" to be able to test everything else besides raising an exception.

[rytilahti]

For the time being, I'd just change the _model inside your test for the dummy. The test code is messy and should be refactored, but it's not a small effort so..

[shred86]

Sorry for the delay - hopefully this will work.

[rytilahti]

LGTM, thanks @shred86 and happy holidays!