Skip to content

Commit

Permalink
Air Conditioning Companion: Target temperature property properly named (
Browse files Browse the repository at this point in the history
#273)

* Target temperature property properly named

* Tests fixed
  • Loading branch information
syssi authored and rytilahti committed Mar 17, 2018
1 parent c9078d9 commit 5d87415
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions miio/airconditioningcompanion.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@ def is_on(self) -> bool:
return self.power == 'on'

@property
def temperature(self) -> Optional[int]:
"""Current temperature."""
def target_temperature(self) -> Optional[int]:
"""Target temperature."""
try:
return int(self.data[1][6:8], 16)
except TypeError:
Expand Down Expand Up @@ -147,15 +147,15 @@ def __repr__(self) -> str:
"load_power=%s, " \
"air_condition_model=%s, " \
"led=%s, " \
"temperature=%s, " \
"target_temperature=%s, " \
"swing_mode=%s, " \
"fan_speed=%s, " \
"mode=%s>" % \
(self.power,
self.load_power,
self.air_condition_model,
self.led,
self.temperature,
self.target_temperature,
self.swing_mode,
self.fan_speed,
self.mode)
Expand Down
6 changes: 3 additions & 3 deletions miio/tests/test_airconditioningcompanion.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,16 +83,16 @@ def test_status(self):
assert self.is_on() is False
assert self.state().load_power == 2
assert self.state().air_condition_model == '010500978022222102'
assert self.state().temperature == 25
assert self.state().target_temperature == 25
assert self.state().swing_mode is False
assert self.state().fan_speed == FanSpeed.Low
assert self.state().mode == OperationMode.Auto
assert self.state().led == 'off'

def test_status_without_temperature(self):
def test_status_without_target_temperature(self):
self.device._reset_state()
self.device.state[1] = None
assert self.state().temperature is None
assert self.state().target_temperature is None

def test_status_without_mode(self):
self.device._reset_state()
Expand Down

0 comments on commit 5d87415

Please sign in to comment.