DesktopFileUtil: add_exec_permission: Return bool instead of int

src/Util/DesktopFileUtil.vala

@@ -5,43 +5,46 @@
 
 namespace Util.DesktopFileUtil {
     /**
-     * The mask bit to get permission info from mode_t (stat.st_mode).
+     * The mask bit to get permission info (``st_mode``) from ``mode_t``.
+     *
+     * Refer to ``man stat.3`` for more info.
      */
     public const Posix.mode_t PERMISSION_BIT = Posix.S_IRWXU | Posix.S_IRWXG | Posix.S_IRWXO;
 
     /**
-     * Add executable permission to the given file at path.
+     * Add execute permission to the given path.
+     *
+     * If the current user already has execute permission to the given path,
+     * this method doesn't change its permission and returns true.
      *
-     * @return          0 when succeed, 1 otherwise.
+     * @param path the path to add execute permission for the current user
+     * @return true when succeed, false otherwise
      */
-    public int add_exec_permission (string path) {
+    public bool add_exec_permission (string path) {
         int ret;
         Posix.Stat sbuf;
 
         ret = Posix.stat (path, out sbuf);
         if (ret != 0) {
-            warning ("Failed to get the current mode of '%s': %s",
-                    path, Posix.strerror (Posix.errno));
-            return 1;
+            warning ("add_exec_permission: Failed to get the current mode of \"%s\": %s",
+                     path, Posix.strerror (Posix.errno));
+            return false;
         }
 
-        Posix.mode_t cur_perm = sbuf.st_mode & PERMISSION_BIT;
+        Posix.mode_t current_permission = sbuf.st_mode & PERMISSION_BIT;
 
-        /*
-         * If the current user already has exec permission to the specified file,
-         * do nothing.
-         */
-        if ((cur_perm & Posix.S_IXUSR) == Posix.S_IXUSR) {
-            return 0;
+        // Do nothing if the current user already has execute permission
+        if ((current_permission & Posix.S_IXUSR) == Posix.S_IXUSR) {
+            return true;
         }
 
-        ret = Posix.chmod (path, cur_perm | Posix.S_IXUSR);
+        ret = Posix.chmod (path, current_permission | Posix.S_IXUSR);
         if (ret != 0) {
-            warning ("Failed to give exec permission to '%s': %s",
-                    path, Posix.strerror (Posix.errno));
-            return 1;
+            warning ("add_exec_permission: Failed to give exec permission to \"%s\": %s",
+                     path, Posix.strerror (Posix.errno));
+            return false;
         }
 
-        return 0;
+        return true;
     }
 }