Flatpak: Regain access to HOME #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it it ideal to restrict filesystem permission, we've faced several issues due to this: - Created desktop entries disappear after reboot/upgrade - The path displayed in the entry is weird (/run/user/1000/...) I thought making Pin It! copy the executable and icon files to ~/.local/share/applications where the desktop file is saved, because it would keep the filesystem permission as small as possible. However, it would need more considerations like the case when the size of the executable or icon file is huge (maybe we need some kind of the progress dialog...) Considering these side effects, I think regaining access to HOME is simpler and better decision here.
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113
Fixes #64
Fixes #61
While it it ideal to restrict filesystem permission, we've faced several issues due to this:
I thought making Pin It! copy the executable and icon files to ~/.local/share/applications where the desktop file is saved, because it would keep the filesystem permission as small as possible. However, it would need more considerations like the case when the size of the executable or icon file is huge (maybe we need some kind of the progress dialog...)
Considering these side effects, I think regaining access to HOME is simpler and better decision here.