Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace Adw.AboutWindow with Adw.AboutDialog #166

Merged
merged 5 commits into from
May 8, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: Replace Adw.AboutWindow with Adw.AboutDialog
ryonakano committed May 8, 2024

Verified

This commit was signed with the committer’s verified signature.
ryonakano Ryo Nakano
commit 38e4f820690f21352f33a929de08dc756aecb501
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -46,7 +46,7 @@ You'll need the following dependencies:

* blueprint-compiler
* [libchcase](https://github.com/ryonakano/chcase)
* libadwaita-1-dev (>= 1.4)
* libadwaita-1-dev (>= 1.5)
* libgranite-7-dev (>= 7.2.0, required only when you build with `granite` feature enabled)
* libgtk4-dev
* libgtksourceview-5-dev
6 changes: 2 additions & 4 deletions src/Application.vala
Original file line number Diff line number Diff line change
@@ -109,12 +109,10 @@ public class Application : Adw.Application {
"Leo https://github.com/lenemter",
};

var about_window = new Adw.AboutWindow.from_appdata (
var about_dialog = new Adw.AboutDialog.from_appdata (
"%s/%s.metainfo.xml".printf (Config.RESOURCE_PREFIX, Config.APP_ID),
null
) {
transient_for = get_active_window (),
modal = true,
version = Config.APP_VERSION,
copyright = "© 2020-2024 Ryo Nakano",
developers = DEVELOPERS,
@@ -127,7 +125,7 @@ public class Application : Adw.Application {
///John Doe https://example.com
translator_credits = _("translator-credits")
};
about_window.present ();
about_dialog.present (get_active_window ());
}

public static int main (string[] args) {
2 changes: 1 addition & 1 deletion src/meson.build
Original file line number Diff line number Diff line change
@@ -17,7 +17,7 @@ endif

dependencies = [
granite_dep,
dependency('libadwaita-1', version: '>= 1.4'),
dependency('libadwaita-1', version: '>= 1.5'),
dependency('gtk4'),
dependency('gtksourceview-5'),
]