Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Port to libadwaita #148

Merged
merged 7 commits into from
Apr 30, 2024
Merged

feat: Port to libadwaita #148

merged 7 commits into from
Apr 30, 2024

Conversation

ryonakano
Copy link
Owner

@ryonakano ryonakano commented Apr 29, 2024 •
edited
Loading

Fixes #147

Changes Summary

  • README.md
    • Update dependency list
  • com.github.ryonakano.konbucase.yml
    • Enable granite build option because this file used to build the app for elementary OS
  • data/resources/ui/main-window.blp
    • Port to libadwaita
  • meson_options.txt
    • Add a build option for elementary OS builds
  • src/Application.vala
    • Subclass Adw.Application
    • Use Adw.Application.style_manager instead of our custom StyleManager which requires Granite
    • Allow using elementary stylesheet on Pantheon
  • src/Define.vala
    • Salvage string definitions from StyleManager.vala which still necessary
  • src/StyleManager.vala
    • Remove in favor of Adw.Application.style_manager
  • src/Util.vala
    • Update conversion methods between Action.state and Adw.ColorScheme
    • Add conversion methods between string representation of GLib.Settings values and Adw.ColorScheme
  • src/View/MainWindow.vala
    • Port to libadwaita
  • src/meson.build
    • Add libgranite to the dependencies
    • Make Granite optional dependency

@ryonakano ryonakano marked this pull request as ready for review April 30, 2024 01:04
@ryonakano ryonakano mentioned this pull request Apr 30, 2024
Closed
@ryonakano ryonakano merged commit 5ddae54 into main Apr 30, 2024
3 checks passed
@ryonakano ryonakano deleted the libadwaita branch April 30, 2024 13:25
@ryonakano ryonakano mentioned this pull request May 4, 2024
Merged
ryonakano added a commit that referenced this pull request May 4, 2024
@ryonakano
docs: Default for Flathub, optionally for AppCenter (#158)
d9b4243 
As we did #148 and #154, we now targets Flathub by default and optionally builds for AppCenter. We do the same thing for screenshots/metainfo too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GTK 4 / LibAdwaita Port
1 participant
@ryonakano