Skip to content

Commit

Permalink
Version 3.1.1-dev.1
Browse files Browse the repository at this point in the history
  • Loading branch information
rydmike committed Jul 12, 2024
1 parent 3167355 commit d373d4c
Show file tree
Hide file tree
Showing 13 changed files with 92 additions and 279 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ on:
paths-ignore:
- "**.md"
release:
branches: [master]
branches: [none]
types: [published]

jobs:
Expand Down
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@

All notable changes to the **FlexSeedScheme** (FSS) package are documented here.

## 3.1.1-dev.1

**July 12, 2024**

**CHORE**

* Experiment to find and remove references from the package to deprecated properties for scoring purposes. The deprecated colors are **NOT** used anymore, but pub's pana analyzer still complains. It happily ignores the "allow usage of self-deprecated members" setting. It also complains about references used in doc comments. This is the first attempt to find and fixe all things it complains about.

## 3.1.0

**July 12, 2024**
Expand Down
124 changes: 32 additions & 92 deletions README.md

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ analyzer:

# Allow self-reference to deprecated members. This is done because otherwise we have
# to annotate every member in every test, assert, etc. when we deprecate something.
deprecated_member_use_from_same_package: ignore
# deprecated_member_use_from_same_package: ignore

# DON'T assign new values to parameters of methods or functions.
#
Expand Down
2 changes: 1 addition & 1 deletion example/lib/core/constants/app_data.dart
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class AppData {
// build numbers.
static const String versionMajor = '3';
static const String versionMinor = '1';
static const String versionPatch = '0';
static const String versionPatch = '1-dev.1';
static const String versionBuild = '01';
static const String version = '$versionMajor.$versionMinor.$versionPatch '
'Build-$versionBuild';
Expand Down
2 changes: 1 addition & 1 deletion example/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ packages:
path: ".."
relative: true
source: path
version: "3.1.0"
version: "3.1.1-dev.1"
flutter:
dependency: "direct main"
description: flutter
Expand Down
2 changes: 1 addition & 1 deletion example/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: flex_seed_scheme_example
description: Example that demonstrate how to use the FlexSeedScheme package.
version: 3.1.0
version: 3.1.1-dev.1
publish_to: 'none'
environment:
sdk: '>=3.0.0 <4.0.0'
Expand Down
32 changes: 14 additions & 18 deletions lib/src/flex/flex_seed_scheme.dart
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ import 'flex_tones.dart';
/// This class is the same concept as Flutter's [ColorScheme] class.
///
/// It is used used to generate a [ColorScheme] based on a modified version of
/// [CorePalette] found in package material_color_utilities. It is a rewrite
/// of [Scheme] found in same "material_color_utilities" package.
/// [CorePalette] found in package material_color_utilities.
///
/// It has two enhancements to makes it more flexible and powerful:
///
Expand Down Expand Up @@ -189,7 +188,7 @@ class FlexSeedScheme {
/// A color that's clearly legible when drawn on [surface].
final int onSurface;

/// A color that's clearly legible when drawn on [surfaceVariant].
/// A alternative color that's clearly legible when drawn on [surface] colors.
final int onSurfaceVariant;

/// A utility color that creates boundaries and emphasis to improve usability.
Expand Down Expand Up @@ -223,16 +222,16 @@ class FlexSeedScheme {

/// A color that typically appears behind scrollable content.
@Deprecated('Use surface instead.')
final int background;
final int? background;

/// A color that's clearly legible when drawn on [background].
@Deprecated('Use onSurface instead.')
final int onBackground;
final int? onBackground;

/// A color variant of [surface] that can be used for differentiation against
/// a component using [surface].
@Deprecated('Use surfaceContainerHighest instead.')
final int surfaceVariant;
final int? surfaceVariant;

/// Private constructor requiring all int color values.
///
Expand Down Expand Up @@ -292,11 +291,12 @@ class FlexSeedScheme {
required this.onInverseSurface,
required this.inversePrimary,
required this.surfaceTint,
//
@Deprecated('Use surface instead.') required this.background,
@Deprecated('Use onSurface instead.') required this.onBackground,
@Deprecated('Use surfaceContainerHighest instead.')
required this.surfaceVariant,
// ignore: unused_element
@Deprecated('Use surface instead.') this.background,
// ignore: unused_element
@Deprecated('Use onSurface instead.') this.onBackground,
// ignore: unused_element
@Deprecated('Use surfaceContainerHighest instead.') this.surfaceVariant,
});

/// Factory that creates a [FlexSeedScheme] based on seed keys and FlexTones
Expand Down Expand Up @@ -394,10 +394,6 @@ class FlexSeedScheme {
onInverseSurface: core.neutral.get(tones.onInverseSurfaceTone),
inversePrimary: core.primary.get(tones.inversePrimaryTone),
surfaceTint: core.primary.get(tones.surfaceTintTone),
// Deprecated colors
background: core.neutral.get(tones.backgroundTone),
onBackground: core.neutral.get(tones.onBackgroundTone),
surfaceVariant: core.neutralVariant.get(tones.surfaceVariantTone),
);
}
}
Expand Down Expand Up @@ -843,13 +839,13 @@ extension SeedColorScheme on ColorScheme {
/// Override color for the seed generated [surfaceTint] color.
Color? surfaceTint,

/// Override color for the seed generated [background] color.
/// Override color for the seed generated background color.
@Deprecated('Use surface instead.') Color? background,

/// Override color for the seed generated [onBackground] color.
/// Override color for the seed generated onBackground color.
@Deprecated('Use onSurface instead.') Color? onBackground,

/// Override color for the seed generated [surfaceVariant] color.
/// Override color for the seed generated surfaceVariant color.
@Deprecated('Use surfaceContainerHighest instead.') Color? surfaceVariant,
}) {
// Assert that a none null value has not been assign to tones and variant
Expand Down
Loading

0 comments on commit d373d4c

Please sign in to comment.