Fixes xhr.status check for usePresignedUpload hook
#134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks! Let me think about best way to reject / throw an error that includes the HTTP status. Think we can come up with something, I wanna see what other AWS libraries are doing before I commit :) |
|
Ok published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue reported here.
💡 Idea
If the promise was settled with the status code, it would enable developers to have fine-grained control over how to handle rejections. For instance, redirecting to another page.
For this to work the Promise would need to resolve a value:
{ status: xhr.status }. The status type could be strict, like HTTPStatusCode.ts.@ryanto thoughts? 💭