Fira Code Nerd Font Mono is not displaying == sign correctly

[Goku-San]

🗹 Requirements

• I have searched the issues for my issue and found nothing related and/or helpful
• I have searched the FAQ for help
• I have searched the Wiki for help

🎯 Subject of the issue

Experienced behavior:
== sign not displaying properly with FiraCode Nerd Font Mono Medium. Few days ago ( Saturday or Sunday ) I updated the Fira Code Nerd Font. Before that everything was displaying correctly.

Expected behavior:
Expect to display properly as with original Fira Code Medium or FiraCode Nerd Font Medium.

If I use FiraCode Nerd Font Medium or Fira Code Medium than icons in vim are clipped.
So if you can please fix the == sign or revert to the patch from 9 days ago, when all was good.

Example symbols:

🔧 Your Setup

• Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)?

  • Please give the full filename
    Fira Code Medium Nerd Font Complete Mono.ttf

  • Where did you get the file from (download link, self patched, source downloaded from link...)
    https://github.com/ryanoasis/nerd-fonts/tree/master/patched-fonts/FiraCode

• Which terminal emulator are you using (e.g. iterm2, urxvt, gnome, konsole)?
  st terminal with ligatures patch

• Are you using OS X, Linux or Windows? And which specific version or distribution?
  Linux - Manjaro XFCE

★ Screenshots (Optional)

st call inside config.h
static char *font = "FiraCode Nerd Font:style=Medium:size=12:antialias=true:autohint=true";

st call inside config.h
static char *font = "FiraCode Nerd Font Mono:style=Medium:size=12:antialias=true:autohint=true";

[Finii]

Thank you for reporting the issue! This reminds me of #973

Wondering why this shows all up now, was I am not aware of any related changes.

The one working was also directly from master ~9 days ago?

[Goku-San]

The working was from master and according to the https://github.com/ryanoasis/nerd-fonts/tree/master/patched-fonts/FiraCode its from ~9 days ago. I can only confirm for Fira Code because I only use them. I install them manually. I check every weekend for updates.
I checked the reported signs from #973 and #934, only the equal sign == is not working.

[Finii]

Can see it 👍 or :-(

This is definitively the same issue, broken ligature. Let see

[Goku-San]

Nope can't see it... 🙁

[Finii]

"Lets see" means ... wait, I start searching for the reason :)

The commit is question in 5d218b1

There I fixed the ligature removal code. Before the commit the code ... did not do much. Afterwards it removed all the tables it was intended to remove.

But obviously the ligature removal data is outdated. It never showed because the ligature removal never happened because it was broken. ...

I guess we should just remove ligature-removal (as it never worked anyhow, at least not in the more recent past).

Do you want or not want ligatures?

[Finii]

And then the next question (because here is night and I have to sleep soon):

I was working in the Seti Icons update and am almost finished. Shall we wait with a bugfix (for the == bug) until Seti update is ready? That will be only in 24h or something.

[Goku-San]

First question ---> I want ligatures

Second question --> Yes, no problem I can wait....

You have I good night rest... we are in the same time zone :)

Thanks for your hard work...

[Finii]

Ah yes...

Here the history of font updates:

$ git log --pretty=format:"%h %ad -- %s by %an" src/unpatched-fonts/FiraCode/Medium/FiraCode-Medium.ttf
78be0e1e7 Tue Dec 7 12:14:51 2021 +1300 -- Add unpatched FiraCode v6.2 by Sean Fausett
d23d0e008 Sat Dec 4 14:36:29 2021 +1300 -- Add unpatched FiraCode v6.1 by Sean Fausett
dea135924 Mon Apr 27 21:31:40 2020 +0200 -- Add unpatched FiraCode v3.1 files by Oliver Hoffmann
2d32a1f44 Sat Jan 18 16:08:10 2020 -0800 -- Updates Fira Code source to v2.0 (#424) by Ryan L McIntyre
dfc31db1d Mon Sep 9 20:27:00 2019 +0200 -- Update unpatched Fira Code fonts to 2.0 by Hugo van Rijswijk
d9ea69ac6 Thu Oct 4 16:21:01 2018 +0200 -- updated FiraCode to version 1.206 by mashehu
ad162ace7 Sat Mar 10 17:39:23 2018 -0500 -- Adds sources for 'ttf' format of FiraCode (WIP #244) by Ryan L McIntyre

But the ligature removal table has never been updated along with it

$ git log --pretty=format:"%h %ad -- %s by %an" src/unpatched-fonts/FiraCode/config.json
a2f56206e Sun Feb 25 15:18:48 2018 -0500 -- Adds new config files (WIP #186) by Ryan L McIntyre

😬

[Finii]

Thanks for your hard work...

You are welcome :-)

The solution is simple and the same as in the Hasklug Issue. Will change that along with the Seti update, like, tomorrow.

[github-actions]

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.