-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comic Shanns is using circumflex instead of caron/wedge #1492
Comments
Even the stand alone caron is not a caron. ![]() Wikipedia explaining how caron should look like ![]() Caron next to Circumflex in Comic Shanns Then I found this here [1]: ![]() which is a Nerd Font patch of Comic Mono, with the correct Caron, BUT the original Comic Mono [2] does not have it?! [1] Patched Comic Mono with diacritics: https://github.com/mavonarx/ComicMonoFonts |
Is there a way for you to patch it on your end? It has been reported upstream in 2021, maybe font abandoned. |
Is the list given in the issue description with the char list (expected behavior) complete?
Sent from Nine
…________________________________
From: Antonín Dach ***@***.***>
Sent: Sunday, March 17, 2024 22:26
To: ryanoasis/nerd-fonts
Cc: Fini; Comment
Subject: Re: [ryanoasis/nerd-fonts] Comic Shanns is using circumflex instead of caron/wedge (Issue #1492)
Is there a way for you to patch it on your end?
It has been reported upstream in 2021, maybe font abandoned.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
|
Yes, but to be sure, here you have all Czech ones
I also checked Slovak diacritics and there is no extra letters Czechs don't use that would be broken. |
Note to self
|
Comic Shanns repos
|
@freed00m These look about right? |
@Finii I think the I tried to look up fonts and can't find any that would have acute like stroke touching the letter. |
[why] The carons are all upside down. The dcaron and tcaron should use an 'apothrophe'. [how] The simplify the fixing of all carons we take the excellent fork ofu Rodrigo Batista de Moraes that (re?)creates the letters with caron from references. Just manually flip the caron and all combined glyphs will be fixed. Create a combining-comma-above-right from the ordinary comma. Reference that for dcaron and tcaron. Rerun `make-bold` which creates the two otf files. Fixes: #1492 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Ok, fixing |
[why] The carons are all upside down. The dcaron and tcaron should use an 'apothrophe'. [how] The simplify the fixing of all carons we take the excellent fork ofu Rodrigo Batista de Moraes that (re?)creates the letters with caron from references. Just manually flip the caron and all combined glyphs will be fixed. Create a combining-comma-above-right from the ordinary comma. Reference that for dcaron and tcaron. Rerun `make-bold` which creates the two otf files. Fixes: #1492 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Yes, Though I am not sure if the view is not cut off top and bottom for the uppercase characters, but if it's there and just violating top bottom line space then it's looking good. |
[why] The carons are all upside down and look like a small circumflex. The dcaron and tcaron use a caron instead of an apothrophe. [how] - Flip caron glyph - Add combining-comma-above-right (shortened version from comma) - Recreate dcaron and tcaron from d/t and that new glyph - Increase version number (patchlevel by one) - Mention Rodrigo in copyright. See also ryanoasis/nerd-fonts#1492 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
That is just an artifact from how Thanks, I will merge. |
[why] The carons are all upside down. The dcaron and tcaron should use an 'apothrophe'. [how] The simplify the fixing of all carons we take the excellent fork ofu Rodrigo Batista de Moraes that (re?)creates the letters with caron from references. Just manually flip the caron and all combined glyphs will be fixed. Create a combining-comma-above-right from the ordinary comma. Reference that for dcaron and tcaron. Rerun `make-bold` which creates the two otf files. Fixes: #1492 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Ah well, that depends on platform and we fix it before we patch: # WIN line metrics obviously wrong, as Nerd Fonts sometimes prefers that, fix it already
font.os2_winascent = font.os2_typoascent
font.os2_windescent = -font.os2_typodescent
font.os2_use_typo_metrics = 1
font.generate('ComicShannsMono-Regular.otf') Excerpt of https://github.com/ryanoasis/nerd-fonts/blob/master/src/unpatched-fonts/ComicShannsMono/make_bold and later
|
[why] The carons are all upside down and look like a small circumflex. The dcaron and tcaron use a caron instead of an apothrophe. [how] - Flip caron glyph - Add combining-comma-above-right (shortened version from comma) - Recreate dcaron and tcaron from d/t and that new glyph - Increase version number (patchlevel by one) - Mention Rodrigo in copyright. See also ryanoasis/nerd-fonts#1492 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
🗹 Requirements
🎯 Subject of the issue
Experienced behavior:
Czech languages use carons for diacritics charaters.
The following sentence contains all of Czech diacritics

"Příliš žluťoučký kůň úpěl ďábelské ódy"
Shows like this
Expected behavior:
řšžčěňŘŠŽČĚŤĎŇ
to have caronťď
is rarity to have caron modified to apostrophe-like stroke instead of caronExample symbols:
🔧 Your Setup
ComicShannsMonoNerdFontMono-Regular.otf
from Arch linux repository
Using foot terminal with sway environment running linux.
| Installed package info:
| Name : otf-comicshanns-nerd
| Version : 3.1.1-1
The text was updated successfully, but these errors were encountered: