Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comic Shanns is using circumflex instead of caron/wedge #1492

Closed
3 tasks done
freed00m opened this issue Jan 19, 2024 · 17 comments · Fixed by #1546
Closed
3 tasks done

Comic Shanns is using circumflex instead of caron/wedge #1492

freed00m opened this issue Jan 19, 2024 · 17 comments · Fixed by #1546

Comments

@freed00m
Copy link

freed00m commented Jan 19, 2024

🗹 Requirements

  • I have searched the issues for my issue and found nothing related and/or helpful
  • I have searched the FAQ for help
  • I have searched the Wiki for help

🎯 Subject of the issue

Experienced behavior:

Czech languages use carons for diacritics charaters.

The following sentence contains all of Czech diacritics
"Příliš žluťoučký kůň úpěl ďábelské ódy"
Shows like this
20240119_23h07m37s_grim

Expected behavior:
řšžčěňŘŠŽČĚŤĎŇto have caron
ťď is rarity to have caron modified to apostrophe-like stroke instead of caron

Example symbols:

🔧 Your Setup

ComicShannsMonoNerdFontMono-Regular.otf
from Arch linux repository

Using foot terminal with sway environment running linux.

| Installed package info:
| Name : otf-comicshanns-nerd
| Version : 3.1.1-1

@Finii
Copy link
Collaborator

Finii commented Jan 28, 2024

Uups that looks indeed strange.

Concentrating on one glyph, ž, codepoint 17e.

Comparing here with Cascadia Code, the error is already in the source font:

Screenshot 2024-01-28 at 15 40 58

And they even drew the glyph completely instead of just combining a regular z with a regular caron, like Cascadia does:

Screenshot 2024-01-28 at 15 42 44

I guess this at least fixes the non-combining chars, which would make it far easier to fix your problem:

I will work a bit on this, maybe we can incorporate the fix upstream.

@Finii
Copy link
Collaborator

Finii commented Jan 28, 2024

Even the stand alone caron is not a caron.
The Breve is ok, though.

Screenshot 2024-01-28 at 16 30 53

Wikipedia explaining how caron should look like

Screenshot 2024-01-28 at 16 31 14

Caron next to Circumflex in Comic Shanns


Then I found this here [1]:

Screenshot 2024-01-28 at 16 50 31

which is a Nerd Font patch of Comic Mono, with the correct Caron, BUT the original Comic Mono [2] does not have it?!
There is no documentation on that patch, and to be honest the diacritics look rather out of place.

[1] Patched Comic Mono with diacritics: https://github.com/mavonarx/ComicMonoFonts
[2] Original Comic Mono: https://github.com/dtinth/comic-mono-font

@freed00m
Copy link
Author

Is there a way for you to patch it on your end?

It has been reported upstream in 2021, maybe font abandoned.

@Finii
Copy link
Collaborator

Finii commented Mar 18, 2024 via email

@freed00m
Copy link
Author

Yes,

but to be sure, here you have all Czech ones

áéěíýóúůžščřďťň
ÁÉĚÍÝÓÚŮŽŠČŘĎŤŇ

I also checked Slovak diacritics and there is no extra letters Czechs don't use that would be broken.

@Finii
Copy link
Collaborator

Finii commented Mar 18, 2024

Note to self

U+00E1 U+00E9 U+011B U+00ED áéěí
U+00FD U+00F3 U+00FA U+016F ýóúů
U+017E U+0161 U+010D U+0159 žščř
U+010F U+0165 U+0148 U+00C1 ďťňÁ
U+00C9 U+011A U+00CD U+00DD ÉĚÍÝ
U+00D3 U+00DA U+016E U+017D ÓÚŮŽ
U+0160 U+010C U+0158 U+010E ŠČŘĎ
U+0164 U+0147 ŤŇ

@Finii
Copy link
Collaborator

Finii commented Mar 18, 2024

Comic Shanns repos

@Finii
Copy link
Collaborator

Finii commented Mar 18, 2024

ťď is rarity to have caron modified to apostrophe-like stroke instead of caron

U+010F U+0165

Seems we should remove the 'real' caron and add an apostrophe thing?

Noto does this for example. But on the other hand this violates 'monospaced'.

image

image

@Finii
Copy link
Collaborator

Finii commented Mar 18, 2024

Iosevka Term...

image

OK, we will do the same.

@Finii
Copy link
Collaborator

Finii commented Mar 18, 2024

@freed00m These look about right?

image

@freed00m
Copy link
Author

freed00m commented Mar 18, 2024

@Finii I think the ď acute like stroke should not be touching, it looks weird like a completely new character.
I think going a bit out of monospace should be acceptable.

I tried to look up fonts and can't find any that would have acute like stroke touching the letter.

image

image

image

image

Finii added a commit that referenced this issue Mar 18, 2024
[why]
The carons are all upside down.
The dcaron and tcaron should use an 'apothrophe'.

[how]
The simplify the fixing of all carons we take the excellent fork ofu
Rodrigo Batista de Moraes that (re?)creates the letters with caron from
references.

Just manually flip the caron and all combined glyphs will be fixed.

Create a combining-comma-above-right from the ordinary comma.

Reference that for dcaron and tcaron.

Rerun `make-bold` which creates the two otf files.

Fixes: #1492

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii mentioned this issue Mar 18, 2024
2 tasks
@Finii
Copy link
Collaborator

Finii commented Mar 18, 2024

I think going a bit out of monospace should be acceptable.

Ok, fixing

@Finii
Copy link
Collaborator

Finii commented Mar 18, 2024

image
ok?

Finii added a commit that referenced this issue Mar 18, 2024
[why]
The carons are all upside down.
The dcaron and tcaron should use an 'apothrophe'.

[how]
The simplify the fixing of all carons we take the excellent fork ofu
Rodrigo Batista de Moraes that (re?)creates the letters with caron from
references.

Just manually flip the caron and all combined glyphs will be fixed.

Create a combining-comma-above-right from the ordinary comma.

Reference that for dcaron and tcaron.

Rerun `make-bold` which creates the two otf files.

Fixes: #1492

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@freed00m
Copy link
Author

Yes,

Though I am not sure if the view is not cut off top and bottom for the uppercase characters, but if it's there and just violating top bottom line space then it's looking good.

Finii added a commit to Finii/comic-shanns-mono-rodrigo that referenced this issue Mar 18, 2024
[why]
The carons are all upside down and look like a small circumflex.
The dcaron and tcaron use a caron instead of an apothrophe.

[how]
- Flip caron glyph
- Add combining-comma-above-right (shortened version from comma)
- Recreate dcaron and tcaron from d/t and that new glyph
- Increase version number (patchlevel by one)
- Mention Rodrigo in copyright.

See also ryanoasis/nerd-fonts#1492

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
Copy link
Collaborator

Finii commented Mar 18, 2024

That is just an artifact from how fontforge determines what to show in this preview.

Thanks, I will merge.

Finii added a commit that referenced this issue Mar 18, 2024
[why]
The carons are all upside down.
The dcaron and tcaron should use an 'apothrophe'.

[how]
The simplify the fixing of all carons we take the excellent fork ofu
Rodrigo Batista de Moraes that (re?)creates the letters with caron from
references.

Just manually flip the caron and all combined glyphs will be fixed.

Create a combining-comma-above-right from the ordinary comma.

Reference that for dcaron and tcaron.

Rerun `make-bold` which creates the two otf files.

Fixes: #1492

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
Copy link
Collaborator

Finii commented Mar 18, 2024

Though I am not sure if the view is not cut off top and bottom for the uppercase characters, but if it's there and just violating top bottom line space then it's looking good.

Ah well, that depends on platform and we fix it before we patch:

# WIN line metrics obviously wrong, as Nerd Fonts sometimes prefers that, fix it already
font.os2_winascent = font.os2_typoascent
font.os2_windescent = -font.os2_typodescent
font.os2_use_typo_metrics = 1

font.generate('ComicShannsMono-Regular.otf')

Excerpt of https://github.com/ryanoasis/nerd-fonts/blob/master/src/unpatched-fonts/ComicShannsMono/make_bold

and later

DEBUG: Naming mode 1
DEBUG: Monospace check: Panose is invalid ([0, 0, 0, 0, 0, 0, 0, 0, 0, 0]); glyph-width-mono True
INFO: Setting Panose 'Family Kind' to 'Latin Text and Display' (was 'Any')
INFO: Setting Panose 'Proportion' to 'Monospaced' (was 'Any')
INFO: Redistributing line gap of 200 (100 top and 100 bottom)
DEBUG: Extended glyphs wider bounding box than basic glyphs
DEBUG: Font has negative right side bearing in extended glyphs
DEBUG: Final font cell dimensions 550 w x 1200 h

Rodrigodd pushed a commit to Rodrigodd/comic-shanns-mono that referenced this issue Mar 18, 2024
[why]
The carons are all upside down and look like a small circumflex.
The dcaron and tcaron use a caron instead of an apothrophe.

[how]
- Flip caron glyph
- Add combining-comma-above-right (shortened version from comma)
- Recreate dcaron and tcaron from d/t and that new glyph
- Increase version number (patchlevel by one)
- Mention Rodrigo in copyright.

See also ryanoasis/nerd-fonts#1492

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants