Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for manager #3

Open
wants to merge 183 commits into
base: celerymanager
Choose a base branch
from
Open

Fix tests for manager #3

wants to merge 183 commits into from

Conversation

bgunnar5
Copy link

@bgunnar5 bgunnar5 commented Oct 1, 2024

This branch should fix the issues we've been having with the test suite and the manager command. It moves the merlin stop-workers and merlin query-workers tests to pytest. This is going to have a bunch of changes from LLNL#490 so it'll look like a lot but really the changed files that you need to focus on are:

  1. .github/workflows/push-pr_workflow.yml
  2. merlin/celery.py
  3. merlin/managers/redis_connection.py
  4. tests/integration/commands/test_stop_and_query_workers.py
  5. tests/integration/definitions.py
  6. tests/integration/helper_funcs.py
  7. tests/integration/test_specs/multiple_workers.yaml

bgunnar5 and others added 30 commits August 4, 2023 16:27
@bgunnar5
Merge branch 'develop' of https://github.com/LLNL/merlin into develop
ec13acf 
pull changes from develop
@bgunnar5
merge latest changes from develop
7c59fc2
@bgunnar5
remove a merge conflict statement that was missed
29573d4
@bgunnar5
add pytest coverage library and add sample_index coverage
f10c896
@bgunnar5
run fix style and add module header
362478e
@bgunnar5
add tests for encryption modules
9339b6b
@bgunnar5
add unit tests for util_sampling
54a31bc
@bgunnar5
run fix-style and fix typo
be02611
@bgunnar5
pull latest changes from develop
a015e3c
@bgunnar5
create directory for context managers and fix issue with an encryptio…
63d22f0 
…n test
@bgunnar5
add a context manager for spinning up/down the redis server
b2a9976
@bgunnar5
Merge remote-tracking branch 'origin/develop' into develop
0ef09bc
@bgunnar5
fix issue with path in one test
35c614a
@bgunnar5
rework CONFIG functionality for testing
638a27e
@bgunnar5
refactor config fixture so it doesn't depend on redis server to be st…
9b342ab 
…arted
@bgunnar5
split CONFIG fixtures into rabbit and redis configs, run fix-style
661ab71
@bgunnar5
add unit tests for broker.py
db1f20a
@bgunnar5
add unit tests for the Config object
896898e
@bgunnar5
update CHANGELOG
2a5148c
@bgunnar5
make CONFIG fixtures more flexible for tests
3d7228e
@bgunnar5
add tests for results_backend.py
525e403
@bgunnar5
fix lint issues for most recent changes
47a0b4e
@bgunnar5
fix filename issue in setup.cfg and move celeryadapter tests to integ…
91a3f2f 
…ration suite
@bgunnar5
add ssl filepaths to mysql config object
78b019b
@bgunnar5
add unit tests for configfile.py
275fbd4
@bgunnar5
add tests for the utils.py file in config/
9669bd0
@bgunnar5
create utilities file and constants file
2a209e5
@bgunnar5
move create_dir function to utils.py
ddb0588
@bgunnar5
add tests for merlin/examples/generator.py
e5bc0fe
@bgunnar5
run fix-style and update changelog
681bd71
@bgunnar5
remove unnecessary dependency
39d09d6
@bgunnar5
update github actions versions to use latest
5f4673b
@bgunnar5
update action versions that didn't save
70e540f
@bgunnar5
merge in new tests for stop and query workers commands
94f8f72
@bgunnar5
run fix-style
d2e85ec
@bgunnar5
move distributed test suite actions back to v2
9c4fca4
@bgunnar5
add 'merlin run' tests and port existing ones to pytest
3a2cafa
@bgunnar5
update CHANGELOG
15d6665
@bgunnar5
add aliased fixture types for typehinting
5844e91
@bgunnar5
add tests for the purge command
085d4b2
@bgunnar5
update CHANGELOG
b36dedc
@bgunnar5
update run command tests to use conditions when appropriate
6758282
@bgunnar5
start work on adding workflow tests
466c276
@bgunnar5
create function and class scoped config fixtures
144246f
@bgunnar5
add Tuple fixture type
0518a48
@bgunnar5
get e2e test of feature_demo workflow running
d577653
@bgunnar5
add check for proper variable substitution in e2e test
983215b
@bgunnar5
generalize functionality to run workflows
977e91c
@bgunnar5
add create_testing_dir fixture
ba3f066
@bgunnar5
port chord error workflow to pytest
b30d796
@bgunnar5
create dataclasses to house common fixtures and reduce fixture import…
8b76db8 
… requirements
@bgunnar5
fix lint issues
c1b39e4
@bgunnar5
remove hard requirement of Annotated type for python 3.7 and 3.8
c450cbd
@bgunnar5
remove distributed test CI and add unit test CI
6a9ede4
@bgunnar5
fix typo in fixture_types and fix lint issues
711ce06
@bgunnar5
run fix-style
088ecc1
@bgunnar5
add check for python2 before adding that condition check
f544644
@bgunnar5
convert local run test to use StepFinishedFilesCount condition
28cae91
@bgunnar5
update CHANGELOG.md
916b5f8
@bgunnar5
pull changes/resolve merge conflicts
3d57fc5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bgunnar5