Add optionItems method to improve performance ...

This method gets an array of Item instances that would be used for each option.

To make it backwards compatible, a method is added to the abstract class. It's not performant, but it works.

The BasicDictionary class overrides it to make it performant.

If someone is making a dictionary that extends the base class, they don't have to override it, but they can if they want to improve the performance.

This is all done because ->options() would get the options, then calling ->get() is happening for each option, which would end up getting all the options for each one. In the case of the file dictionary for example, this means the file is read and parsed for each line in the file.

src/Dictionaries/BasicDictionary.php

@@ -16,11 +16,17 @@ public function get(string $key): ?Item
     }
 
     public function options(?string $search = null): array
+    {
+        return collect($this->optionItems($search))
+            ->mapWithKeys(fn (Item $item) => [$item->value() => $item->label()])
+            ->all();
+    }
+
+    public function optionItems(?string $search = null): array
     {
         return $this
             ->getFilteredItems()
             ->when($search, fn ($collection) => $collection->filter(fn ($item) => $this->matchesSearchQuery($search, $item)))
-            ->mapWithKeys(fn (Item $item) => [$item->value() => $item->label()])
             ->all();
     }
 

src/Dictionaries/Dictionary.php

@@ -68,4 +68,11 @@ private function getInferredGqlType($value)
 
         return GraphQL::string();
     }
+
+    public function optionItems(?string $search = null): array
+    {
+        return collect($this->options($search))
+            ->map(fn ($label, $value) => new Item($value, $label, $this->get($value)->extra()))
+            ->all();
+    }
 }

src/Tags/Dictionary/Dictionary.php

@@ -47,8 +47,8 @@ private function loop($handle)
             throw new DictionaryNotFoundException($handle);
         }
 
-        $options = (new DataCollection($dictionary->options($search)))
-            ->map(fn ($label, $value) => new DictionaryItem($dictionary->get($value)->toArray()))
+        $options = (new DataCollection($dictionary->optionItems($search)))
+            ->map(fn ($item) => new DictionaryItem($item->toArray()))
             ->values();
 
         $query = (new ItemQueryBuilder)->withItems($options);