Don't set termTemplate and template if they are the defaults

ryanmitchell · Jan 30, 2024 · a3d2a17 · a3d2a17
1 parent 0da35cc
commit a3d2a17
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/Http/Controllers/CP/Taxonomies/TaxonomiesController.php b/src/Http/Controllers/CP/Taxonomies/TaxonomiesController.php
@@ -133,8 +133,8 @@ public function edit($taxonomy)
             'collections' => $taxonomy->collections()->map->handle()->all(),
             'sites' => $taxonomy->sites()->all(),
             'preview_targets' => $taxonomy->basePreviewTargets(),
-            'term_template' => $taxonomy->termTemplate(),
-            'template' => $taxonomy->template(),
+            'term_template' => $taxonomy->termTemplate,
+            'template' => $taxonomy->template,
             'layout' => $taxonomy->layout(),
         ];
 

diff --git a/src/Taxonomies/Taxonomy.php b/src/Taxonomies/Taxonomy.php
@@ -383,6 +383,13 @@ public function termTemplate($termTemplate = null)
 
                 return $termTemplate;
             })
+            ->setter(function ($termTemplate) {
+                if (! $termTemplate) {
+                    return;
+                }
+
+                return $termTemplate;
+            })
             ->args(func_get_args());
     }
 
@@ -403,6 +410,13 @@ public function template($template = null)
 
                 return $template;
             })
+            ->setter(function ($template) {
+                if (! $template) {
+                    return;
+                }
+
+                return $template;
+            })
             ->args(func_get_args());
     }