Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #116.
Problem
The
templater
is supposed to replace the placeholder parts of the translation string with the interpolated data. It will skip over the parts of the translation string that are not placeholders. It does this by setting amatched
variable with the interpolated data, or leaving it undefined if there is no interpolation needed. Currently it fails to detect if the interpolated data is falsy (0
,""
), and thus returns the literal string in the translation.Changes
I have made it detect any data value except undefined, so you can pass
0
or an empty string in the data and have it render correctly.