Allow passing of custom getState function #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
+ Coverage 95.54% 95.56% +0.01%
==========================================
Files 6 6
Lines 247 248 +1
Branches 74 75 +1
==========================================
+ Hits 236 237 +1
Misses 10 10
Partials 1 1
Continue to review full report at Codecov.
|
|
@thchia looks good. Also noticed you updated the docs 👍 |
ryandrewjohnson
approved these changes
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #82.
Changes
Added an optional
getState()prop toLocalizeProvider. If passed, it will be used to accessstate.localizeinstead of the default dot notation.Note that the localize state itself is always a plain JS object, so there should be no need to consider any changes deeper than this.