Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools import appears to be invalid #33

Closed
Skarlso opened this issue Feb 28, 2023 · 2 comments
Closed

Tools import appears to be invalid #33

Skarlso opened this issue Feb 28, 2023 · 2 comments

Comments

@Skarlso
Copy link

Skarlso commented Feb 28, 2023

When trying to build or compile this library included in another project that happens to use the build tag tools this library fails with:

tools.go:5:8: import "github.com/t-yuki/gocover-cobertura" is a program, not an importable package

Because that import statement appears to be incorrect. :)
@Skarlso Skarlso mentioned this issue Feb 28, 2023
Closed
@ryancurrah
Copy link
Owner

ryancurrah commented Feb 28, 2023 •
edited
Loading

Installing golangci-lint from source is not recommended. You should use a binary installation.

Note: such go install/go get installation aren't guaranteed to work. We recommend using binary installation.

https://golangci-lint.run/usage/install/

@Skarlso
Copy link
Author

Skarlso commented Mar 1, 2023

Well I mean. Even if we don't install but I'm just a contributor who happens to have tools exported as a build tag I won't be able to build this project now, yes?

bryanv added a commit to bryanv/vm-operator that referenced this issue Mar 1, 2023
@bryanv
Bump golangci-lint and remove unused tools
a8a45fd 
Our prior version of golangci-lint is not compatible with go
1.20 [1] so update that now to front run our go version bump.
Fix some low hangning text/ linter excludes.

Switch to a unique tools build tag to work around golangci-lint
dependency compile failure [2].

While here remove some old Jenkins code coverage tools that are
no longer needed.

[1] - golangci/golangci-lint#3565
[2] - ryancurrah/gomodguard#33
bryanv added a commit to bryanv/vm-operator that referenced this issue Mar 1, 2023
@bryanv
Bump golangci-lint and remove unused tools
a16a127 
Our prior version of golangci-lint is not compatible with go
1.20 [1] so update that now to front run our go version bump.
Fix some low hanging text/ linter excludes.

Switch to a unique tools build tag to work around golangci-lint
dependency compile failure [2].

While here remove some old Jenkins code coverage tools that are
no longer needed.

[1] - golangci/golangci-lint#3565
[2] - ryancurrah/gomodguard#33
bryanv added a commit to bryanv/vm-operator that referenced this issue Mar 1, 2023
@bryanv
Bump golangci-lint and remove unused tools
ea31066 
Our prior version of golangci-lint is not compatible with go
1.20 [1] so update that now to front run our go version bump.
Fix some low hanging text/ linter excludes.

Switch to a unique tools build tag to work around golangci-lint
dependency compile failure [2].

While here remove some old Jenkins test and code coverage tools
that are no longer needed.

[1] - golangci/golangci-lint#3565
[2] - ryancurrah/gomodguard#33
@bryanv bryanv mentioned this issue Mar 1, 2023
Merged
@hrak hrak mentioned this issue Mar 16, 2023
Merged
@srm09 srm09 mentioned this issue Apr 5, 2023
Merged
@mrfelton mrfelton mentioned this issue Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Skarlso @ryancurrah