This repository has been archived by the owner on Nov 28, 2018. It is now read-only.
Cidr ranges #7
Merged
Cidr ranges #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an array of CIDR blocks were given, if the first block did not contain the ip address then notBannedIp would be set to true. Then when the next loop through the CIDR blocks occured, even though the IP was found and was on a blacklist, notBannedIp would still be true therefore allowing access to the ip address. The solution was to make sure if we found an ip and the mode was set to 'deny' that notBannedIp should be set back to false.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug when using array of CIDR blocks
When an array of CIDR blocks were given, if the first block did not contain the ip address then
notBannedIpwould be set to true. Then when the next loop through the CIDR blocks occurred, even though the IP was found and was on a blacklist,notBannedIpwould still be true therefore allowing access to the ip address.The solution was to make sure if we found an ip and the mode was set to 'deny' that notBannedIp should be set back to false.
Fixes #6