refactor tests to use Ember Addon Tests #154
Conversation
| @@ -105,7 +105,7 @@ module.exports = { | |||
| // - application has ember-cli-fastboot dependency. | |||
| this._needsFastBootSupport = this._config.enabled && | |||
| this._config.delivery.includes('header') && | |||
| new VersionChecker(this.project).for('ember-cli-fastboot').exists(); | |||
| this.project.findAddonByName('ember-cli-fastboot') !== null; | |||
There was a problem hiding this comment.
Ember CLI Version Checker does not work well within yarn workspaces. It reports wrongly that a dependency exists if that dependency is installed in the workspace even if it's not a direct nor indirect dependency of the package.
|
@sandstrom This is the pull request that I promised in #100 (comment). |
|
@jelhan Awesome! 💯 🎉 I've looked at the diff and looks great! But I don't have much experience with any of the two test frameworks, so I can't really give any useful feedback or extra pair of eyes 👀. All I could hope to find would be spelling mistakes etc. |
jelhan
changed the title
| sudo: false | ||
| dist: trusty | ||
| dist: xenial |
There was a problem hiding this comment.
CI failed due to outdated yarn version. This change is inline with latest addon blueprint.
|
It seems as if one test is still flickering even after using a more recent yarn version:
Also the tests for Ember CLI beta are failing. But for that version not randomly but constantly. I can't reproduce either of these issues locally. To be honest I hope they are related to TravisCI. But even the current situation is better than the one before. Ember CLI addon tests caused the test suite to break apart on nearly every change. This slowed down development dramatically. If no concerns are raised I will merge this one by the end of today. |
jelhan
changed the title
delete-merged-branch
bot
deleted the
refactor-to-use-ember-addon-tests
branch
This merge requests refactors the test suite to use Ember Addon Tests instead of Ember CLI Addon Tests.
Ember CLI Addon Tests were unstable and slow. CI pipeline was breaking due to small changes in timing and order of tests. Some tests needed to be executed in different processes to prevent leakage. This caused the tests to be sometimes grouped to not break Ember CLI Addon Tests rather than for readability.
Ember Addon Tests could be seen as a modernized rewrite of Ember CLI Addon Tests utilizing yarn workspaces. It should also provide a better performance but I haven't benchmarked.